Skip to content

[PTD] Land 'to_std' utility parser fix #93209 #94023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[PTD] Land 'to_std' utility parser fix #93209 #94023

wants to merge 3 commits into from

Conversation

fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Feb 3, 2023 •
edited by pytorchmergebot
Loading

Stack from ghstack (oldest at bottom):

Land #93209 faster.

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 3, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94023

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 20cb303:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@fduwjj
Copy link
Contributor Author

fduwjj commented Feb 3, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@fduwjj
Update on "Land 'to_std' utility parser #93209"
ecb73ed 

Land #93209 faster.


[ghstack-poisoned]
@fduwjj fduwjj added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 3, 2023
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/fduwjj/69/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/94023)

@fduwjj fduwjj changed the title Land 'to_std' utility parser #93209 Land 'to_std' utility parser fix #93209 Feb 3, 2023
@fduwjj fduwjj changed the title Land 'to_std' utility parser fix #93209 [PTD] Land 'to_std' utility parser fix #93209 Feb 3, 2023
wz337
wz337 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fduwjj
Copy link
Contributor Author

fduwjj commented Feb 3, 2023

@pytrochbot merge

fduwjj added a commit that referenced this pull request Feb 3, 2023
@fduwjj
Land 'to_std' utility parser #93209
d841d12 
ghstack-source-id: 3e6dc88
Pull Request resolved: #94023
@fduwjj
Copy link
Contributor Author

fduwjj commented Feb 3, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/fduwjj/69/head branch June 8, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wz337 wz337 wz337 approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (miscellaneous)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fduwjj @pytorchmergebot @wz337