Implement reshape_as #9452
Closed
Implement reshape_as #9452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added tests 2. Added doc string 3. Remove view_as redundant definition from tensor.py
vishwakftw
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
ssnl
reviewed
Jul 15, 2018
torch/_tensor_docs.py
Outdated
| reshape_as(other) -> Tensor | ||
|
|
||
| Returns this tensor as the same shape as :attr:`other`. | ||
| ``self.reshape_as(other)`` is equivalent to ``self.reshape(other.shape)``. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ssnl
reviewed
Jul 15, 2018
| r""" | ||
| view_as(other) -> Tensor | ||
|
|
||
| View this tensor as the same size as :attr:`other`. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Looks great in general! |
There was a problem hiding this comment.
@ssnl has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks @vishwakftw ! |
vishwakftw
force-pushed
the
resize_as-patch
branch
from
8e0be12 to
50210ba
Compare
ssnl
approved these changes
Jul 16, 2018
|
CI failures look fake |
ezyang
approved these changes
Jul 17, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 17, 2018
Summary: 1. Added tests 2. Added doc string 3. Remove view_as redundant definition from tensor.py Closes #9416 Pull Request resolved: pytorch/pytorch#9452 Differential Revision: D8851794 Pulled By: ezyang fbshipit-source-id: 0aa0430dd0a174e1a5caddbc50a7e2c9eb7802bc
goldsborough
pushed a commit
to goldsborough/pytorch
that referenced
this pull request
Jul 20, 2018
Summary: 1. Added tests 2. Added doc string 3. Remove view_as redundant definition from tensor.py Closes pytorch#9416 Pull Request resolved: pytorch#9452 Differential Revision: D8851794 Pulled By: ezyang fbshipit-source-id: 0aa0430dd0a174e1a5caddbc50a7e2c9eb7802bc
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: 1. Added tests 2. Added doc string 3. Remove view_as redundant definition from tensor.py Closes pytorch#9416 Pull Request resolved: pytorch#9452 Differential Revision: D8851794 Pulled By: ezyang fbshipit-source-id: 0aa0430dd0a174e1a5caddbc50a7e2c9eb7802bc
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: 1. Added tests 2. Added doc string 3. Remove view_as redundant definition from tensor.py Closes pytorch#9416 Pull Request resolved: pytorch#9452 Differential Revision: D8851794 Pulled By: ezyang fbshipit-source-id: 0aa0430dd0a174e1a5caddbc50a7e2c9eb7802bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9416