Re-enable rocm tests that have been fixed in rocm 1.8.2 #9862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bddppq need to update the bare metal as well. let's find a good time to do that. |
There was a problem hiding this comment.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
yinghai
approved these changes
Jul 26, 2018
|
@petrex these tests seem to be passing fine, so I'm going to land this now. |
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: petrex Pull Request resolved: pytorch#9862 Differential Revision: D9012520 Pulled By: bddppq fbshipit-source-id: cdcc184e23befa8dbd1bc44d59bd25766aac33d0
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: petrex Pull Request resolved: pytorch#9862 Differential Revision: D9012520 Pulled By: bddppq fbshipit-source-id: cdcc184e23befa8dbd1bc44d59bd25766aac33d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@petrex