Skip to content

RFC-0001: Add method __torch_function__ RFC. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 31, 2020
Merged

RFC-0001: Add method __torch_function__ RFC. #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0e33cf2
Add method __torch_function__ RFC.
hameerabbasi Jan 24, 2020
686e4cf
Address feedback by @ezyang.
hameerabbasi Jan 27, 2020
049dfac
Add more detail to the proposal.
hameerabbasi Jan 30, 2020
469258b
Fix up proposal as suggested by @rgommers.
hameerabbasi Feb 10, 2020
802f5d8
Add line wraps.
hameerabbasi Feb 10, 2020
064a3a5
Add a statement about granularity.
hameerabbasi Feb 10, 2020
d829cb6
Modify performance numbers.
hameerabbasi Feb 13, 2020
44915da
Address review from @rgommers.
hameerabbasi Feb 16, 2020
c668106
Add more detail about performance implications of the proposal.
hameerabbasi Feb 28, 2020
69feaea
Clarify multiple-inheritance.
hameerabbasi Feb 28, 2020
199015b
Clarify how complex types will be handled.
hameerabbasi Feb 28, 2020
d192652
Respond to review from @ezyang.
hameerabbasi Mar 3, 2020
51526eb
Update __add__ example.
hameerabbasi Mar 9, 2020
7149aa1
Update certain out of date parts.
hameerabbasi Mar 10, 2020
b4ab8a6
Change make_subclass to as_subclass.
hameerabbasi Mar 17, 2020
cb335a0
Add headers,
hameerabbasi Apr 27, 2020
552ba37
This commit addresses the following action items:
hameerabbasi Aug 10, 2020
4a82ea7
Move method explanation to appendix.
hameerabbasi Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
**/.DS_STORE
Loading