Make TorchText installable from direct reference #1154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to make `pip install https://github.com/pytorch/text` succeed `setup.py` should have logic to initialize submodules Add `check_submodules()` routine to setup.py to check if 'third_party/re2/CMakeLists.txt' is present on the filesystem and attempt to initialize submodules if it is not
malfet
force-pushed
the
malfet/make-torchtext-installable-from-direct-source
branch
from
3036a2b to
26ffbe5
Compare
cpuhrsch
reviewed
Feb 13, 2021
| third_party_dir = ROOT_DIR / 'third_party' | ||
| if not (third_party_dir / 're2' / 'CMakeFiles.txt').exists(): | ||
| print(' --- third_party/re2/CMakeFiles.txt do not exist, trying to init submodules') | ||
| try: |
There was a problem hiding this comment.
PyTorch fails and asks the user to do it manually. I worry that this might cause issues when someone wants to debug / modify the submodules and then subsequently runs setup.py. Are there similar plans for PyTorch as well?
There was a problem hiding this comment.
@cpuhrsch yes, I plan to make similar change for pytorch as well, although Pytorch is less likely to be built directly from source (building TorchText using direct link takes less than 15 min, whereas for PyTorch, especially with GPU support will likely to take more than an hour)
There was a problem hiding this comment.
What is the context of this work? Are we going to do the same for torchaudio (which I support)?
mthrok
approved these changes
Feb 16, 2021
mthrok
added a commit
to mthrok/text
that referenced
this pull request
Jun 23, 2022
This commit adds `git` submodule initialization commands at the beginning of setup, so that third party modules become available automatically. This makes it possible to install torchtext with a command like `pip install --no-use-pep517 git+https://github.com/pytorch/text.git` See also: - pytorch#1154 - pytorch/audio#1966
mthrok
added a commit
that referenced
this pull request
Jun 23, 2022
* Automatically initialize submodule This commit adds `git` submodule initialization commands at the beginning of setup, so that third party modules become available automatically. This makes it possible to install torchtext with a command like `pip install --no-use-pep517 git+https://github.com/pytorch/text.git` See also: - #1154 - pytorch/audio#1966
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make
pip install https://github.com/pytorch/textsucceedsetup.pyshould have logic to initialize submodulesAdd
check_submodules()routine to setup.py to check if'third_party/re2/CMakeLists.txt' is present on the filesystem and
attempt to initialize submodules if it is not