Updating TorchData DataPipe API usages #1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nayef211
approved these changes
Mar 28, 2022
Do I need to rebase this branch? Otherwise, I don't think the CI will pick up the change to install |
Yup I think you need to rebase on the latest master |
NivekT
force-pushed
the
UpdateDeprecation
branch
from
2b195ad to
4667670
Compare
|
I don't think the CI failures are related to your PR. Feel free to merge this 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better consistency among its API names, TorchData deprecated/renamed a few DataPipes' methods in its beta release. This PR update torchtext's usages to align with the latest TorchData API.
Basically, we are updating
.read_from_ARCHIVE()to.load_from_ARCHIVE().There should be no functional changes for torchtext at all. For details about the renaming and deprecation, see the following issue.
The lint failure in CI is pre-existing.
The issue with "ci/circleci: unittests" failing during builds is fixed by this PR: