Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

larryliu0820
Copy link
Contributor

Summary:

Added a script to build C++ runner for ET and AOTI. Updated README.md to ask users to run it.

Made some improvement on building speed, by reducing duplicate build command. Now we can rely on install_requirements.sh to install all of the C++ libraries needed for runner.

This depends on ExecuTorch PR pytorch/executorch#3349

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Summary:

Added a script to build C++ runner for ET and AOTI. Updated README.md to
ask users to run it.

Made some improvement on building speed, by reducing duplicate build
command. Now we can rely on `install_requirements.sh` to install all of
the C++ libraries needed for runner.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@larryliu0820 larryliu0820 requested a review from mikekgfb April 25, 2024 07:50
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 25, 2024
@mikekgfb
Copy link
Contributor

@larryliu0820 can we add a build task for build_native.sh to pull.yml please?

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mikekgfb mikekgfb merged commit f544040 into main Apr 25, 2024
@mikekgfb mikekgfb deleted the build_native branch April 25, 2024 19:06
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Add build_native.sh and add README.md

Summary:

Added a script to build C++ runner for ET and AOTI. Updated README.md to
ask users to run it.

Made some improvement on building speed, by reducing duplicate build
command. Now we can rely on `install_requirements.sh` to install all of
the C++ libraries needed for runner.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Revert custom ops change

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add build_native.sh to CI job

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add README for building native runner for aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Add build_native.sh and add README.md

Summary:

Added a script to build C++ runner for ET and AOTI. Updated README.md to
ask users to run it.

Made some improvement on building speed, by reducing duplicate build
command. Now we can rely on `install_requirements.sh` to install all of
the C++ libraries needed for runner.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Revert custom ops change

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add build_native.sh to CI job

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add README for building native runner for aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Add build_native.sh and add README.md

Summary:

Added a script to build C++ runner for ET and AOTI. Updated README.md to
ask users to run it.

Made some improvement on building speed, by reducing duplicate build
command. Now we can rely on `install_requirements.sh` to install all of
the C++ libraries needed for runner.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Revert custom ops change

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add build_native.sh to CI job

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add README for building native runner for aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Add build_native.sh and add README.md

Summary:

Added a script to build C++ runner for ET and AOTI. Updated README.md to
ask users to run it.

Made some improvement on building speed, by reducing duplicate build
command. Now we can rely on `install_requirements.sh` to install all of
the C++ libraries needed for runner.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Revert custom ops change

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add build_native.sh to CI job

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add README for building native runner for aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Add build_native.sh and add README.md

Summary:

Added a script to build C++ runner for ET and AOTI. Updated README.md to
ask users to run it.

Made some improvement on building speed, by reducing duplicate build
command. Now we can rely on `install_requirements.sh` to install all of
the C++ libraries needed for runner.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Revert custom ops change

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add build_native.sh to CI job

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add README for building native runner for aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Add build_native.sh and add README.md

Summary:

Added a script to build C++ runner for ET and AOTI. Updated README.md to
ask users to run it.

Made some improvement on building speed, by reducing duplicate build
command. Now we can rely on `install_requirements.sh` to install all of
the C++ libraries needed for runner.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Revert custom ops change

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add build_native.sh to CI job

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Add README for building native runner for aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants