Skip to content

Use AudioStreamOptions in AudioEncoder #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented May 23, 2025

This PR bundles some of the C++ AudioEncoder parameters into an AudioStreamOptions object. This makes it consistent with decoding, and makes it easier to figure out which parameters define desired properties from the user (like the desired number of channel of the encoded output).

This is based on #697 which isn't merged yet so it's easier to review by just looking at 70ae1a1

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 23, 2025
@NicolasHug NicolasHug merged commit ba44fdb into pytorch:main May 27, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants