Skip to content

Enabling few more torchbench models with AOT Autograd #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Apr 7, 2022

Copy link
Contributor

@jansel jansel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor nit. Also fix lints.

self.gm = normalize_ir(gm, self.example_inputs)
except Exception:
log.debug("TorchDynamo unable to remove mutation")
self.gm = gm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line isn't needed with your addition on l36

@jansel
Copy link
Contributor

jansel commented Apr 7, 2022

For lints you may need to do make lint-deps format to get the right version of black.

@anijain2305 anijain2305 force-pushed the add_fixes branch 2 times, most recently from 37c560f to 7975732 Compare April 7, 2022 20:56
@anijain2305 anijain2305 merged commit bf90b8c into pytorch:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants