Split of "[TorchRec][PT2] KJT custom op for 1d lengths input" (#2163) #2176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h#2163) Summary: Pull Request resolved: pytorch#2163 X-link: pytorch/FBGEMM#2774 # context * move the `tensor.view(-1, stride)` from python into the operator (c++) * make the PT2 complier happy * reference: D58948987 # notes * not sure if we should directly change the op call in the jagged_tensor * tested on CPU and GPU * backward/autograd not tested Differential Revision: D59031938
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59031938 |
|
This pull request has been reverted by b8a1c40. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/FBGEMM#2774
context
tensor.view(-1, stride)from python into the operator (c++)notes
Differential Revision: D59031938