Propagate proper embedding_shard_info when constructing TBE #2876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72421135 |
levythu
force-pushed
the
export-D72421135
branch
from
d5a77a5 to
cdf4bad
Compare
levythu
added a commit
to levythu/torchrec
that referenced
this pull request
Apr 14, 2025
…2876) Summary: This will pass in the right information about shard context to TBE's new parameter. It also did a bit of variable renaming to avoid name shadowing and remove pyre suppression Reviewed By: ge0405 Differential Revision: D72421135
…2876) Summary: Pull Request resolved: pytorch#2876 This will pass in the right information about shard context to TBE's new parameter. It also did a bit of variable renaming to avoid name shadowing and remove pyre suppression Reviewed By: ge0405 Differential Revision: D72421135
|
This pull request was exported from Phabricator. Differential Revision: D72421135 |
levythu
force-pushed
the
export-D72421135
branch
from
cdf4bad to
2087e77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This will pass in the right information about shard context to TBE's new parameter.
It also did a bit of variable renaming to avoid name shadowing and remove pyre suppression
Reviewed By: ge0405
Differential Revision: D72421135