Skip to content

[Qwen3] Fix model arg computation for MoE model #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2025
Merged

[Qwen3] Fix model arg computation for MoE model #1704

merged 4 commits into from
Sep 12, 2025

Conversation

wwwjn
Copy link
Contributor

@wwwjn wwwjn commented Sep 12, 2025

as titled

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 12, 2025
@wwwjn wwwjn marked this pull request as ready for review September 12, 2025 04:41
tianyu-l
tianyu-l approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@tianyu-l tianyu-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix linting

@wwwjn wwwjn merged commit d240be0 into main Sep 12, 2025
8 checks passed
@tianyu-l tianyu-l deleted the param_fix branch September 12, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyu-l tianyu-l tianyu-l approved these changes

@HosseinKaviani-H HosseinKaviani-H Awaiting requested review from HosseinKaviani-H

@fegin fegin Awaiting requested review from fegin fegin is a code owner

@wconstab wconstab Awaiting requested review from wconstab wconstab is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wwwjn @tianyu-l