-
Notifications
You must be signed in to change notification settings - Fork 551
[mxfp8 MoE training] Support mxfp8 all to all in expert parallel #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielvegamyhre
wants to merge
10
commits into
pytorch:main
Choose a base branch
from
danielvegamyhre:mx-a2a
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4527f8b
to
bba9c6a
Compare
fde6de2
to
a48e631
Compare
a48e631
to
89bac2b
Compare
89bac2b
to
0a0d676
Compare
0a0d676
to
751a472
Compare
af79e9a
to
bdbdd45
Compare
bdbdd45
to
bf6d943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
"default"
or"mxfp8"
impl"mxfp8"
impl uses torchao's newto_mxfp8_a2a_dequant
, which has the exact same API as functional collectiveall_to_all_single_autograd
and is differentiable, so it can be used as a drop-in replacement for the default a2a impl.to_mxfp8_a2a_dequant
works as follows:Performance
Single node benchmarks with 4xB200
Llama4 16e default configs; FSDP=4, EP=4; AC=none; compile=True; seq_len=8192; local_bs=8
Reduced num layers from 48 -> 2 to avoid OOM in single node setting
Debug model config:
Additional context on design/implementation choices
Additional background on motivation
30% of llama4 model profiled runtime is all2all comms
47% avg runtime devoted to MoE comms in profiled OSS models