Skip to content

Conversation

fegin
Copy link
Contributor

@fegin fegin commented Oct 5, 2025

Seed checkpoint loading requires checkpoint.enable to be True. However, when using seed checkpoints, users typically don't want to save subsequent checkpoints since seed checkpoints serve verification purposes only.

Seed checkpoint loading requires checkpoint.enable to be True.  However, when using seed checkpoints, users typically don't want to save subsequent checkpoints since seed checkpoints serve verification purposes only.
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 5, 2025
Copy link
Contributor

@tianyu-l tianyu-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be implemented as a separate script, but this way shares more code.
"""

load_seed_checkpoint_only: bool = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this logic could be used / useful not just for seed checkpoint only, but any checkpoint in general? e.g. when we debug uneven FSDP vocab dim sharding

Do you think we can rename it to load_only (and update the comment)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used initial_load_path and initial_load_in_hf parameter a lot, sometimes I only want to load from HF checkpoints and don't want to save checkpoints. I think initial_load_path can be used together with the new parameter together for my use case as well.

I agree we can name is more general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants