turn off dynamic shape for torch.compile #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as titled. This could make 1-D and 2-D works We should figure out why dynamic shape gets turned on as a follow up
facebook-github-bot
added
the
CLA Signed
awgu
approved these changes
May 2, 2024
| @@ -18,7 +18,7 @@ save_tb_folder = "tb" | |||
| [model] | |||
| name = "llama3" | |||
| flavor = "8B" | |||
| norm_type = "fused_rmsnorm" # [layernorm / np_layernorm / rmsnorm / fused_rmsnorm] | |||
| norm_type = "rmsnorm" # [layernorm / np_layernorm / rmsnorm / fused_rmsnorm] | |||
There was a problem hiding this comment.
yeah I feel it's a bit painful to switch between rmsnorm and fused_rmsnorm locally when switching between 1-D and 2-D sharding, so I changed rmsnorm to default, we can always default to fused_rmsnorm once @tianyu-l changes the fused_rmsnorm registration #296.
Let me know if you think we should default to fused_rmsnorm for 8B
There was a problem hiding this comment.
Keeping it as rmsnorm sounds good to me!
tianyu-l
pushed a commit
to tianyu-l/torchtitan_intern24
that referenced
this pull request
Aug 16, 2024
as titled. This could make 1-D and 2-D works with the lastest main build. thanks @bdhirsh for all the fixes! We should figure out why dynamic shape gets turned on as a follow up
philippguevorguian
pushed a commit
to YerevaNN/YNNtitan
that referenced
this pull request
Aug 17, 2024
as titled. This could make 1-D and 2-D works with the lastest main build. thanks @bdhirsh for all the fixes! We should figure out why dynamic shape gets turned on as a follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as titled. This could make 1-D and 2-D works with the lastest main build. thanks @bdhirsh for all the fixes!
We should figure out why dynamic shape gets turned on as a follow up