Skip to content

Make test_runner.py warn on non-empty output dir #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2024
Merged

Make test_runner.py warn on non-empty output dir #343

merged 1 commit into from
May 17, 2024

Conversation

wconstab
Copy link
Contributor

@wconstab wconstab commented May 17, 2024 •
edited
Loading

@wconstab
Update
d1d7ec6 
[ghstack-poisoned]
@wconstab wconstab mentioned this pull request May 17, 2024
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 17, 2024
wconstab added a commit that referenced this pull request May 17, 2024
@wconstab
Make test_runner.py warn on non-empty output dir
86cbfcc 
also wrap logic into functions and clean up global vars

ghstack-source-id: 815c582
Pull Request resolved: #343
kwen2501
kwen2501 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@wconstab wconstab mentioned this pull request May 17, 2024
Merged
@wconstab wconstab merged commit d1d7ec6 into gh/wconstab/26/base May 17, 2024
wconstab added a commit that referenced this pull request May 17, 2024
@wconstab
Make test_runner.py warn on non-empty output dir
f2c3a11 
also wrap logic into functions and clean up global vars

ghstack-source-id: 815c582
Pull Request resolved: #343
@wconstab wconstab deleted the gh/wconstab/26/head branch May 17, 2024 21:59
tianyu-l pushed a commit that referenced this pull request May 28, 2024
@wconstab @tianyu-l
Make test_runner.py warn on non-empty output dir
3602679 
also wrap logic into functions and clean up global vars

ghstack-source-id: 815c582
Pull Request resolved: #343
tianyu-l pushed a commit to tianyu-l/torchtitan_intern24 that referenced this pull request Aug 16, 2024
@wconstab
Make test_runner.py warn on non-empty output dir
7cb4fed 
also wrap logic into functions and clean up global vars

ghstack-source-id: 815c582
Pull Request resolved: pytorch#343
tianyu-l pushed a commit that referenced this pull request Aug 16, 2024
@wconstab @tianyu-l
Make test_runner.py warn on non-empty output dir
f53c0fc 
also wrap logic into functions and clean up global vars

ghstack-source-id: 815c582
Pull Request resolved: #343
philippguevorguian pushed a commit to YerevaNN/YNNtitan that referenced this pull request Aug 17, 2024
@wconstab
Make test_runner.py warn on non-empty output dir
3baba7b 
also wrap logic into functions and clean up global vars

ghstack-source-id: 815c582
Pull Request resolved: pytorch#343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wconstab @kwen2501 @facebook-github-bot