Skip to content

[do not review][example] train.py without pp #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tianyu-l
Copy link
Contributor

@tianyu-l tianyu-l commented Aug 4, 2024

Stack from ghstack (oldest at bottom):

The LoC of train.py drops from 422 to 349 (saves ~17%)

tianyu-l added a commit that referenced this pull request Aug 4, 2024
ghstack-source-id: 5f9325d
Pull Request resolved: #501
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 4, 2024
@tianyu-l tianyu-l marked this pull request as draft August 4, 2024 05:29
The LoC of `train.py` drops from 422 to 349 (saves ~17%)

[ghstack-poisoned]
tianyu-l added a commit that referenced this pull request Aug 5, 2024
ghstack-source-id: 2bc35b0
Pull Request resolved: #501
@tianyu-l tianyu-l force-pushed the gh/tianyu-l/18/head branch from 7eb417b to d69eb22 Compare August 16, 2024 21:00
tianyu-l added a commit that referenced this pull request Aug 16, 2024
ghstack-source-id: 2bc35b0
Pull Request resolved: #501
@tianyu-l
Copy link
Contributor Author

simplification is done in #510

@tianyu-l tianyu-l closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants