support infinite loop over alpaca dataset #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
XilunWu
reviewed
Feb 23, 2024
Comment on lines
+77
to
+78
| if not self.infinite: | ||
| break |
There was a problem hiding this comment.
should we add some mechanic to allow a stop? self.infinite is a constant after being initialized.
There was a problem hiding this comment.
I think cmd + c should be sufficient?
wanchaol
approved these changes
Feb 23, 2024
| yield input, label | ||
| while len(all_tokens) >= max_buffer_token_len: | ||
| x = torch.LongTensor(all_tokens[:max_buffer_token_len]) | ||
| # batched_x = x.reshape(self.batch_size, -1) |
There was a problem hiding this comment.
nit: we can delete the staled comment?
Comment on lines
+77
to
+78
| if not self.infinite: | ||
| break |
There was a problem hiding this comment.
I think cmd + c should be sufficient?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Previously, alpaca dataset is consumed up after only ~50 iterations with 8 data parallel ranks and 8 batch size. This PR adds the (default) option to loop infinitely on the dataset, so that we can unblock integrating other functionalities. Note that loss-related metrics should be read with caution as this will cause overfit.
Update: moved to #92 because migrating to pytorch/ confused ghstack.