add bunch of cleanups and design principle section #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clena up the repo to: 1. remove unused files 2. delete not used code comments
facebook-github-bot
added
the
CLA Signed
yifuwang
approved these changes
Feb 23, 2024
lessw2020
reviewed
Feb 23, 2024
README.md
Outdated
|
|
||
| ## Design Principles | ||
|
|
||
| TorchTrain is a native PyTorch library with various training techniques, it utilizes the PyTorch ecosystem for things like data loading (i.e. HuggingFace datasets), the core functionality is written in PyTorch. |
There was a problem hiding this comment.
nit on grammar:
TorchTrain is a native PyTorch library with various training techniques. While it utilizes the PyTorch ecosystem for things like data loading (i.e. HuggingFace datasets), the core functionality is written in PyTorch.
tianyu-l
approved these changes
Feb 23, 2024
lessw2020
reviewed
Feb 23, 2024
README.md
Outdated
| @@ -67,3 +67,12 @@ If your gpu count per node is not 8, adjust: | |||
| ```#SBATCH --gpus-per-task``` | |||
|
|
|||
| in the SBATCH command section. | |||
|
|
|||
|
|
|||
| ## Design Principles | |||
There was a problem hiding this comment.
Shouldn't this go near the top of the readme? It's a (good) intro and design/architecture guide, I would not put it at the bottom.
lessw2020
approved these changes
Feb 23, 2024
lessw2020
pushed a commit
that referenced
this pull request
Apr 18, 2024
philippguevorguian
pushed a commit
to YerevaNN/YNNtitan
that referenced
this pull request
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.