-
Notifications
You must be signed in to change notification settings - Fork 141
(torchx/specs) Add intermediate helper method to parse component arguments #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D80215193 |
ethanbwaite
added a commit
that referenced
this pull request
Aug 14, 2025
…ments (#1097) Summary: Extracts logic from `materialize_appdef` to new helper method to standardize a way to parse component function arguments Differential Revision: D80215193
6927de3
to
1d0e9f6
Compare
This pull request was exported from Phabricator. Differential Revision: D80215193 |
1d0e9f6
to
f49723a
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 16, 2025
…ments (#1097) Summary: Extracts logic from `materialize_appdef` to new helper method to standardize a way to parse component function arguments Differential Revision: D80215193
f49723a
to
a2d68a4
Compare
This pull request was exported from Phabricator. Differential Revision: D80215193 |
ethanbwaite
added a commit
that referenced
this pull request
Aug 18, 2025
…ments (#1097) Summary: Extracts logic from `materialize_appdef` to new helper method to standardize a way to parse component function arguments Differential Revision: D80215193
a2d68a4
to
45ff733
Compare
This pull request was exported from Phabricator. Differential Revision: D80215193 |
45ff733
to
7cf483e
Compare
ethanbwaite
added a commit
that referenced
this pull request
Aug 20, 2025
…ments (#1097) Summary: Extracts logic from `materialize_appdef` to new helper method to standardize a way to parse component function arguments Differential Revision: D80215193
7cf483e
to
9b3c574
Compare
This pull request was exported from Phabricator. Differential Revision: D80215193 |
9b3c574
to
3e68380
Compare
kiukchung
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Extracts logic from
materialize_appdef
to new helper method to standardize a way to parse component function argumentsDifferential Revision: D80215193