Skip to content

Refactor BoxOps tests to use parameterize #4500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fmassa opened this issue Sep 29, 2021 · 4 comments · Fixed by #5380
Closed

Refactor BoxOps tests to use parameterize #4500

fmassa opened this issue Sep 29, 2021 · 4 comments · Fixed by #5380
Assignees
@HeungwooLee
Labels
code quality good first issue help wanted module: tests

Comments

@fmassa
Copy link
Member

fmassa commented Sep 29, 2021 •
edited by pytorch-probot bot
Loading

Initially brought in #4472 (review)

TestBoxArea, TestBoxIoU and TestGenBoxIoU are all very related and perform a single test (or two if we consider the newly added JIT test).
We can probably refactor the implementations so that they follow the same base class, and use pytest.parameterize, so that each configuration is displayed as an independent test.

cc @pmeier
@Chandan-h-509
Copy link

Hey @fmassa I would like to work on this issue.

@Chandan-h-509 Chandan-h-509 mentioned this issue Oct 12, 2021
Closed
@datumbox
Copy link
Contributor

The ticket is up for grabs!

@HeungwooLee
Copy link
Contributor

I will work on this one.

@datumbox
Copy link
Contributor

datumbox commented Feb 1, 2022

Sounds good, it's yours @HeungwooLee.

@HeungwooLee HeungwooLee mentioned this issue Feb 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeungwooLee HeungwooLee

Labels
code quality good first issue help wanted module: tests
Projects
None yet
Milestone
No milestone
5 participants
@datumbox @pmeier @fmassa @Chandan-h-509 @HeungwooLee