Add JIT tests for box_area, box_iou, genaralized_box_iou #4472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oke-aditya
commented
Sep 23, 2021
| @@ -999,6 +1015,14 @@ def gen_iou_check(box, expected, tolerance=1e-4): | |||
| expected = torch.tensor([[1.0, 0.9933, 0.9673], [0.9933, 1.0, 0.9737], [0.9673, 0.9737, 1.0]]) | |||
| gen_iou_check(box_tensor, expected, tolerance=0.002 if dtype == torch.float16 else 1e-3) | |||
|
|
|||
| def test_giou_jit(self): | |||
| box_tensor = torch.tensor([[0, 0, 100, 100], [0, 0, 50, 50], [200, 200, 300, 300]], dtype=torch.float) | |||
There was a problem hiding this comment.
I remember adding the IoU tests, and calculating by hand an year ago. Great that they are still used! 😄
#2642
|
Hi @datumbox! Is this worth checking and adding (extra testing doesn't hurt in my opinion) ? |
datumbox
approved these changes
Sep 28, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
Summary: Co-authored-by: Francisco Massa <[email protected]> Reviewed By: datumbox Differential Revision: D31268017 fbshipit-source-id: 530047152deae83ef61b1a8ba26cf37039cf7c9d
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
Co-authored-by: Francisco Massa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are JIT scriptable and compatible, but it would be nice to test it I think.
cc @pmeier @NicolasHug @datumbox