Skip to content

Refactor Models builders to make them reusable on Prototype #4676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
datumbox opened this issue Oct 20, 2021 · 0 comments · Fixed by #4646 or #4656
Closed
2 tasks done

Refactor Models builders to make them reusable on Prototype #4676

datumbox opened this issue Oct 20, 2021 · 0 comments · Fixed by #4646 or #4656

Comments

@datumbox
Copy link
Contributor

datumbox commented Oct 20, 2021

🚀 The feature

The current model builders are hard to reuse from the prototype area, leading to large amounts of copy-pasting. It would be good to refactor the space in a BC manner so that we can reuse as many parts as we can:

  • Segmentation models:
    • Update them to follow the standard convention of defining the builders on the same file as their class.
    • Make private model builders reusable from prototype.
    • Clean up the implementations and expose publicly variables that are currently pushed to kwargs.
  • Detection models:
    • Make private model builders reusable from prototype.
    • Refactor the VGG16 Features weights mechanism on SSD to work well with the proposed weights prototype.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant