-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Add the missing ArgumentParser types on Reference Scripts #4694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
4 tasks
If it is ok, I want to resolve this issue :) |
You got it @puhuk. Looking forward to your PR. |
puhuk
added a commit
to puhuk/vision
that referenced
this issue
Oct 22, 2021
To resolve issue pytorch#4694
puhuk
added a commit
to puhuk/vision
that referenced
this issue
Oct 22, 2021
Add missing types on argument parser
datumbox
added a commit
that referenced
this issue
Oct 24, 2021
* Add type to default argument To resolve issue #4694 * Resolve issue #4694 Add missing types on argument parser * Update with ufmt formatted with ufmt * Updated with review Updated with review * Update type of arguments Add train.py from video_classification, similarity and train_quantization.py Co-authored-by: Vasilis Vryniotis <[email protected]>
facebook-github-bot
pushed a commit
that referenced
this issue
Oct 26, 2021
…ers (#4724) Summary: * Add type to default argument To resolve issue #4694 * Resolve issue #4694 Add missing types on argument parser * Update with ufmt formatted with ufmt * Updated with review Updated with review * Update type of arguments Add train.py from video_classification, similarity and train_quantization.py Reviewed By: NicolasHug Differential Revision: D31916335 fbshipit-source-id: a717a3cac868b567db57b84a545ad9363820179b Co-authored-by: Vasilis Vryniotis <[email protected]>
cyyever
pushed a commit
to cyyever/vision
that referenced
this issue
Nov 16, 2021
…rch#4724) * Add type to default argument To resolve issue pytorch#4694 * Resolve issue pytorch#4694 Add missing types on argument parser * Update with ufmt formatted with ufmt * Updated with review Updated with review * Update type of arguments Add train.py from video_classification, similarity and train_quantization.py Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
🚀 The feature
Quite a few arguments on the Reference Scripts are missing the
type
parameter. Most of them seem to be strings.Examples:
vision/references/classification/train.py
Lines 379 to 380 in e08c9e3
vision/references/detection/train.py
Line 80 in e08c9e3
vision/references/segmentation/train.py
Line 247 in e08c9e3
It would be good to add them and improve the arguments by providing better descriptions on the
help
argument.The text was updated successfully, but these errors were encountered: