Skip to content

Add the missing ArgumentParser types on Reference Scripts #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datumbox opened this issue Oct 21, 2021 · 2 comments
Closed

Add the missing ArgumentParser types on Reference Scripts #4694

datumbox opened this issue Oct 21, 2021 · 2 comments

Comments

@datumbox
Copy link
Contributor

datumbox commented Oct 21, 2021

🚀 The feature

Quite a few arguments on the Reference Scripts are missing the type parameter. Most of them seem to be strings.

Examples:

parser.add_argument("--output-dir", default=".", help="path where to save")
parser.add_argument("--resume", default="", help="resume from checkpoint")

parser.add_argument("--lr-scheduler", default="multisteplr", help="the lr scheduler (default: multisteplr)")

parser.add_argument("--dist-url", default="env://", help="url used to set up distributed training")

It would be good to add them and improve the arguments by providing better descriptions on the help argument.

@puhuk
Copy link
Contributor

puhuk commented Oct 22, 2021

If it is ok, I want to resolve this issue :)

@datumbox
Copy link
Contributor Author

You got it @puhuk. Looking forward to your PR.

puhuk added a commit to puhuk/vision that referenced this issue Oct 22, 2021
puhuk added a commit to puhuk/vision that referenced this issue Oct 22, 2021
Add missing types on argument parser
datumbox added a commit that referenced this issue Oct 24, 2021
* Add type to default argument

To resolve issue #4694

* Resolve issue #4694

Add missing types on argument parser

* Update with ufmt

formatted with ufmt

* Updated with review

Updated with review

* Update type of arguments

Add train.py from video_classification, similarity and train_quantization.py

Co-authored-by: Vasilis Vryniotis <[email protected]>
facebook-github-bot pushed a commit that referenced this issue Oct 26, 2021
…ers (#4724)

Summary:
* Add type to default argument

To resolve issue #4694

* Resolve issue #4694

Add missing types on argument parser

* Update with ufmt

formatted with ufmt

* Updated with review

Updated with review

* Update type of arguments

Add train.py from video_classification, similarity and train_quantization.py

Reviewed By: NicolasHug

Differential Revision: D31916335

fbshipit-source-id: a717a3cac868b567db57b84a545ad9363820179b

Co-authored-by: Vasilis Vryniotis <[email protected]>
@datumbox datumbox closed this as completed Nov 2, 2021
cyyever pushed a commit to cyyever/vision that referenced this issue Nov 16, 2021
…rch#4724)

* Add type to default argument

To resolve issue pytorch#4694

* Resolve issue pytorch#4694

Add missing types on argument parser

* Update with ufmt

formatted with ufmt

* Updated with review

Updated with review

* Update type of arguments

Add train.py from video_classification, similarity and train_quantization.py

Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants