Skip to content

Revamping our classification models docs #5833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
15 tasks done
NicolasHug opened this issue Apr 19, 2022 · 33 comments
Closed
15 tasks done

Revamping our classification models docs #5833

NicolasHug opened this issue Apr 19, 2022 · 33 comments

Comments

@NicolasHug
Copy link
Member

NicolasHug commented Apr 19, 2022

We're re-writing our models docs to make them clearer, simpler, and to properly document the upcoming multi-weight API. This issue is about adding docs for the classification models.

Perhaps this is something @oke-aditya @YosuaMichael @lezwon @zhiqwang would be interested in :) ?

Our latest new docs are currently here (this link is likely outdated by the time you look at it, but it doesn't matter; the skeleton is there). We created a separate section that will eventually be merged into the main one. We have documented a few models, but most of them are still missing. The list of models that still need docs is listed below. If you'd like to participate, please comment below with a message saying "I'm working on XYZ" where XYZ is a model, so that others don't pick the same as you do. To keep things simple, please submit one PR per model, but feel free to contribute more than one model.

How to write docs for a model

Note: below are detailed instructions. This makes it look more complicated than it actually is. Don't be scared!

A great place to start is to look a the changes in this PR that documents SqueezeNet. You'll need to do exactly the same for your model:

To build the docs locally, please look at our contributing guide. You won't need to worry about the gallery example, so always use make html-noplot instead of make html to save time.

Please don't hesitate to ping us if you need any help / guidance or if you have any question!


Classification models that need docs are:

@YosuaMichael
Copy link
Contributor

This is great @NicolasHug !
I would like to try adding doc for RegNet and VisionTransformer.

@datumbox
Copy link
Contributor

Great initiative to split into bite-sized chunks. :)

Tagging a few more regulars in case they are interested in helping: @xiaohu2015 @abhi-glitchhg @frgfm @yassineAlouini

@lezwon
Copy link
Contributor

lezwon commented Apr 20, 2022

Hey @NicolasHug, I'd like to start off with densenet.

@oke-aditya
Copy link
Contributor

I will take MobileNets :) v2 v3

@abhi-glitchhg
Copy link
Contributor

I would like to take ResNext.

@zhiqwang
Copy link
Contributor

I would like to take ShuffleNet v2

@xiaohu2015
Copy link
Contributor

xiaohu2015 commented Apr 20, 2022

I would like to take ConvNeXt.

@abhi-glitchhg

This comment was marked as resolved.

@xiaohu2015
Copy link
Contributor

@xiaohu2015 I think @YosuaMichael has already picked VisionTransformer.

Ok, I choose another model ConvNeXt

@yassineAlouini
Copy link
Contributor

yassineAlouini commented Apr 20, 2022

EfficientNet and EfficientNet v2 if it is still for grabs. 😸

@datumbox
Copy link
Contributor

@yassineAlouini It's yours! :)

Note that EfficientNet V1 and V2 are implemented on the same class (EfficientNet). On the documentation we want to document them separately because they are 2 different papers.

@frgfm
Copy link
Contributor

frgfm commented Apr 20, 2022

Hi @NicolasHug @datumbox, thanks for the tag 🙂
I'm on holidays until next Monday, I'll take a look at what's left then! Great idea to improve the doc by the way 🙌

@yassineAlouini
Copy link
Contributor

@yassineAlouini It's yours! :)

Note that EfficientNet V1 and V2 are implemented on the same class (EfficientNet). On the documentation we want to document them separately because they are 2 different papers.

Thanks. Should I work on both documentations then? Or at least start with EfficientNet? 🤔

@NicolasHug
Copy link
Member Author

@yassineAlouini sure, feel free to do both!

@yassineAlouini
Copy link
Contributor

One last question: how should we link the PR that we create? Is there a list of issues or do we just reference this?

@NicolasHug
Copy link
Member Author

You can just reference this one!

@yassineAlouini
Copy link
Contributor

yassineAlouini commented Apr 26, 2022

Since my previous MRs have been merged, I can work on GoogLeNet doc if it is available. 👌

@NicolasHug
Copy link
Member Author

Please pick as many as you'd like @yassineAlouini :)

@yassineAlouini
Copy link
Contributor

Next: Alexnet.

@abhi-glitchhg
Copy link
Contributor

I would take Wide Resnet

@frgfm
Copy link
Contributor

frgfm commented Apr 26, 2022

Alright I'm back 😁
Anyone wants to lend me one of those models? @oke-aditya mind if I take MobileNetV3 while you handle MobileNetV2 for instance? 🙏

@oke-aditya
Copy link
Contributor

oke-aditya commented Apr 27, 2022

Sure Take v2. I'm back too. Was sick :(

@NicolasHug
Copy link
Member Author

Thank you so much everyone who participated so far, your help is greatly appreciated!

For those who would like to pick more models, I just opened this new issue to document the rest of the models (semantic segmantation and object detection) #5897

@frgfm
Copy link
Contributor

frgfm commented Apr 27, 2022

Sad to hear this @oke-aditya :/ Happy to take care of V3 as well while I'm at it if you want!

@oke-aditya
Copy link
Contributor

I Will take care of v3, slowly getting back to work. :)

@zhiqwang
Copy link
Contributor

Hi @NicolasHug , Sorry for delay, I will finish ShuffleNetV2 by tomorrow.

@NicolasHug
Copy link
Member Author

No rush @zhiqwang :)

@jdsgomes
Copy link
Contributor

I will work on the MNASNet - seems to be the last one

@yassineAlouini
Copy link
Contributor

@NicolasHug Shouldn't the GoogLeNet be checked in the list? 🤔 Asking so that no one does the job again. 😄

@NicolasHug
Copy link
Member Author

Looks like we're all done! Thank you so much everyone for your help <3 !

@yassineAlouini
Copy link
Contributor

Next is object detection/segmentation I guess? 🤔 @NicolasHug

@NicolasHug
Copy link
Member Author

@yassineAlouini I think we took care of that in #5897

The only remaining docs are the ones for the classification Quantized models. https://github.com/pytorch/vision/tree/main/torchvision/models/quantization. I think I'll create another issue for these ones soon, let me know if you'd be interested!

@yassineAlouini
Copy link
Contributor

@NicolasHug I see, that's great. I am interested in helping. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests