-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Revamping our classification models docs #5833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is great @NicolasHug ! |
Great initiative to split into bite-sized chunks. :) Tagging a few more regulars in case they are interested in helping: @xiaohu2015 @abhi-glitchhg @frgfm @yassineAlouini |
Hey @NicolasHug, I'd like to start off with densenet. |
I will take MobileNets :) v2 v3 |
I would like to take |
I would like to take |
I would like to take |
This comment was marked as resolved.
This comment was marked as resolved.
Ok, I choose another model ConvNeXt |
|
@yassineAlouini It's yours! :) Note that EfficientNet V1 and V2 are implemented on the same class (EfficientNet). On the documentation we want to document them separately because they are 2 different papers. |
Hi @NicolasHug @datumbox, thanks for the tag 🙂 |
Thanks. Should I work on both documentations then? Or at least start with EfficientNet? 🤔 |
@yassineAlouini sure, feel free to do both! |
One last question: how should we link the PR that we create? Is there a list of issues or do we just reference this? |
You can just reference this one! |
Since my previous MRs have been merged, I can work on |
Please pick as many as you'd like @yassineAlouini :) |
Next: |
I would take |
Alright I'm back 😁 |
Sure Take v2. I'm back too. Was sick :( |
Thank you so much everyone who participated so far, your help is greatly appreciated! For those who would like to pick more models, I just opened this new issue to document the rest of the models (semantic segmantation and object detection) #5897 |
Sad to hear this @oke-aditya :/ Happy to take care of V3 as well while I'm at it if you want! |
I Will take care of v3, slowly getting back to work. :) |
Hi @NicolasHug , Sorry for delay, I will finish |
No rush @zhiqwang :) |
I will work on the MNASNet - seems to be the last one |
@NicolasHug Shouldn't the |
Looks like we're all done! Thank you so much everyone for your help <3 ! |
Next is object detection/segmentation I guess? 🤔 @NicolasHug |
@yassineAlouini I think we took care of that in #5897 The only remaining docs are the ones for the classification Quantized models. https://github.com/pytorch/vision/tree/main/torchvision/models/quantization. I think I'll create another issue for these ones soon, let me know if you'd be interested! |
@NicolasHug I see, that's great. I am interested in helping. 👌 |
We're re-writing our models docs to make them clearer, simpler, and to properly document the upcoming multi-weight API. This issue is about adding docs for the classification models.
Perhaps this is something @oke-aditya @YosuaMichael @lezwon @zhiqwang would be interested in :) ?
Our latest new docs are currently here (this link is likely outdated by the time you look at it, but it doesn't matter; the skeleton is there). We created a separate section that will eventually be merged into the main one. We have documented a few models, but most of them are still missing. The list of models that still need docs is listed below. If you'd like to participate, please comment below with a message saying "I'm working on XYZ" where XYZ is a model, so that others don't pick the same as you do. To keep things simple, please submit one PR per model, but feel free to contribute more than one model.
How to write docs for a model
Note: below are detailed instructions. This makes it look more complicated than it actually is. Don't be scared!
A great place to start is to look a the changes in this PR that documents SqueezeNet. You'll need to do exactly the same for your model:
.rst
file in https://github.com/pytorch/vision/tree/main/docs/source/models. The file should look like this, with a link to the original paper, and a list of the corresponding model builders. It should also mention the base model class and link to the.py
file where it is defined..rst
suffix). Please keep the list alphabetically sortedTo build the docs locally, please look at our contributing guide. You won't need to worry about the gallery example, so always use
make html-noplot
instead ofmake html
to save time.Please don't hesitate to ping us if you need any help / guidance or if you have any question!
Classification models that need docs are:
ShuffleNet V2
#5921The text was updated successfully, but these errors were encountered: