Skip to content

updating mnasnet docs #5920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 3, 2022
Merged

updating mnasnet docs #5920

merged 7 commits into from
May 3, 2022

Conversation

jdsgomes
Copy link
Contributor

Part of #5833

Adding revamp docs for MNASNET.

cc @NicolasHug

@jdsgomes jdsgomes marked this pull request as draft April 28, 2022 19:53
@jdsgomes jdsgomes marked this pull request as ready for review April 28, 2022 21:02
@NicolasHug
Copy link
Member

Thanks @jdsgomes

I noticed that the 1.3 and 0.75 weights are missing / non-existent. I added them to the docs and then removed them after realizing it made the doc generation fail. Do you know if we're planning to support pre-trained weights for these models before the next release? If we don't, we might nee to change our docs to indicate that no pre-trained weights exist (and possibly remove the existence of the parameter altogether)

@jdsgomes
Copy link
Contributor Author

jdsgomes commented May 3, 2022

Thanks @jdsgomes

I noticed that the 1.3 and 0.75 weights are missing / non-existent. I added them to the docs and then removed them after realizing it made the doc generation fail. Do you know if we're planning to support pre-trained weights for these models before the next release? If we don't, we might nee to change our docs to indicate that no pre-trained weights exist (and possibly remove the existence of the parameter altogether)

I don't know if we have plans to add those before next release, lets follow up with this offline. Merging for now, thank you for the review!

@jdsgomes jdsgomes merged commit aef2b58 into pytorch:main May 3, 2022
@github-actions
Copy link

github-actions bot commented May 3, 2022

Hey @jdsgomes!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug
Copy link
Member

@jdsgomes it might still be worth updating the current docs, which for now contain ambiguous / incorrect info:

The following model builders can be used to instanciate an MNASNet model, with or
without pre-trained weights

The weights parameter is also documeted as

The pretrained weights to use

(with broken links). But if we don't support pre-trained weights, we should make sure to indicate it clearly. ATM, users will believe that we support pre-trained weights while we don't.

facebook-github-bot pushed a commit that referenced this pull request May 7, 2022
Summary:
* updating mnasnet docs

* fix bug

* fix lint

* fix end of file

* fix linting

* Add missing weights

Reviewed By: YosuaMichael

Differential Revision: D36204391

fbshipit-source-id: 7c7c3cab2488f4e37507c8c3a970687cb25a899c

Co-authored-by: Nicolas Hug <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants