-
Notifications
You must be signed in to change notification settings - Fork 7.1k
updating mnasnet docs #5920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating mnasnet docs #5920
Conversation
Thanks @jdsgomes I noticed that the 1.3 and 0.75 weights are missing / non-existent. I added them to the docs and then removed them after realizing it made the doc generation fail. Do you know if we're planning to support pre-trained weights for these models before the next release? If we don't, we might nee to change our docs to indicate that no pre-trained weights exist (and possibly remove the existence of the parameter altogether) |
I don't know if we have plans to add those before next release, lets follow up with this offline. Merging for now, thank you for the review! |
Hey @jdsgomes! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
@jdsgomes it might still be worth updating the current docs, which for now contain ambiguous / incorrect info:
The
(with broken links). But if we don't support pre-trained weights, we should make sure to indicate it clearly. ATM, users will believe that we support pre-trained weights while we don't. |
Summary: * updating mnasnet docs * fix bug * fix lint * fix end of file * fix linting * Add missing weights Reviewed By: YosuaMichael Differential Revision: D36204391 fbshipit-source-id: 7c7c3cab2488f4e37507c8c3a970687cb25a899c Co-authored-by: Nicolas Hug <[email protected]>
Part of #5833
Adding revamp docs for MNASNET.
cc @NicolasHug