Skip to content

Put back MPS builds #8478

Closed
Closed
@NicolasHug

Description

@NicolasHug

(this is a follow-up and more up-to-date version of #8456)

The M1 CI jobs were broken for ~1 week (#8456) and it turns out the problem was caused by the MPS build. We deactivated the MPS builds in #8472 and the M1 jobs (all using macos-m1-stable) are now green.

We have to put back the MPS build before the release though, otherwise torchvision won't provide MPS-compatible custom ops.

In #8476 (macos-m1-stable), #8473 (macos-m1-13) and #8477 (macos-m1-14) I'm trying to add back those MPS builds, but they all fail with the same error as previously seen back in #8456:

  File "/Users/ec2-user/runner/_work/vision/vision/pytorch/vision/test/smoke_test.py", line 7, in <module>
    import torchvision
  File "/Users/ec2-user/runner/_work/vision/vision/pytorch/vision/torchvision/__init__.py", line 10, in <module>
    from torchvision import _meta_registrations, datasets, io, models, ops, transforms, utils  # usort:skip
  File "/Users/ec2-user/runner/_work/vision/vision/pytorch/vision/torchvision/_meta_registrations.py", line 164, in <module>
    def meta_nms(dets, scores, iou_threshold):
  File "/opt/homebrew/Caskroom/miniconda/base/envs/ci/lib/python3.10/site-packages/torch/library.py", line 653, in register
    use_lib._register_fake(op_name, func, _stacklevel=stacklevel + 1)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/ci/lib/python3.10/site-packages/torch/library.py", line 153, in _register_fake
    handle = entry.abstract_impl.register(func_to_register, source)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/ci/lib/python3.10/site-packages/torch/_library/abstract_impl.py", line 30, in register
    if torch._C._dispatch_has_kernel_for_dispatch_key(self.qualname, "Meta"):
RuntimeError: operator torchvision::nms does not exist

CC @malfet @huydhn

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions