Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of our own image reading functions. This PR adds PNG reading functions using libpng. @fmassa what are your thoughts on these?
RGB
(and notRGBA
). Should it stay this way?is_png
tells us weather the data is a PNG image or not.read_png
reads the image and returns atorch::Tensor
.torch::Tensor
.C++
and compare the read image withOpenCV
(or some other library) output (which is not good because it hasOpenCV
as a dependency). Or we can expose toPython
and compare withPIL
output.