Skip to content

Adds optional fill colour to rotate #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2019
Merged

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Aug 30, 2019

Closes #1277

@pmeier
Copy link
Collaborator Author

pmeier commented Aug 30, 2019

The failed C++ test seems to be unrelated to this PR.


Edit: Rebased from master after the recent CI changes.

@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #1280 into master will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
- Coverage   65.85%   65.84%   -0.02%     
==========================================
  Files          75       75              
  Lines        5782     5785       +3     
  Branches      884      885       +1     
==========================================
+ Hits         3808     3809       +1     
  Misses       1710     1710              
- Partials      264      266       +2
Impacted Files Coverage Δ
torchvision/transforms/transforms.py 80.98% <100%> (-0.16%) ⬇️
torchvision/transforms/functional.py 71.26% <75%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a91fe72...e70c4e3. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit a129b6b into pytorch:master Sep 11, 2019
@pmeier pmeier deleted the add_fill_to_rotate branch September 12, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Torchvision functional rotate should have a fill option
3 participants