remove BC-breaking changes #1560
Conversation
test/test_models.py
Outdated
| script_test_models = [ | ||
| "deeplabv3_resnet101", | ||
| # "deeplabv3_resnet101", temp disabled |
There was a problem hiding this comment.
If this is all going in before a release it's better to just wait until pytorch#28988 lands then land this PR so these tests never have to be disabled
There was a problem hiding this comment.
AFAIK There's a minor release of torchvision coming up, this PR is for that release
There was a problem hiding this comment.
The minor release of torchvision didn't contain the BC-breaking commits, so I think we can wait until pytorch#28988 lands to merge this PR, thoughts?
There was a problem hiding this comment.
Okay cool, in that case yes we can wait.
There was a problem hiding this comment.
@eellison pytorch/pytorch#28988 has landed, can you re-enable this test?
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
=========================================
Coverage ? 65.95%
=========================================
Files ? 90
Lines ? 7047
Branches ? 1070
=========================================
Hits ? 4648
Misses ? 2094
Partials ? 305
Continue to review full report at Codecov.
|
test/test_models.py
Outdated
| script_test_models = [ | ||
| "deeplabv3_resnet101", | ||
| # "deeplabv3_resnet101", temp disabled |
There was a problem hiding this comment.
The minor release of torchvision didn't contain the BC-breaking commits, so I think we can wait until pytorch#28988 lands to merge this PR, thoughts?
|
Merging this as the failures are unrelated. |
IntermediateLayerGetterandDenseBlockwere re-written to be supported in script, along the way introducing BC changes that required_load_from_state_dictlogic.This removes those changes, moving them to
ModuleDict. Once pytorch/pytorch#28988 lands we can re-enable these scripting tests.