Add scriptable transform: center_crop, five crop and ten_crop #1615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fmassa , I am planning to first add all the crops with the tests and then would be requesting you for the review. Thanks |
Codecov Report
@@ Coverage Diff @@
## master #1615 +/- ##
==========================================
+ Coverage 65.97% 65.97% +<.01%
==========================================
Files 91 91
Lines 7229 7262 +33
Branches 1095 1100 +5
==========================================
+ Hits 4769 4791 +22
- Misses 2153 2159 +6
- Partials 307 312 +5
Continue to review full report at Codecov.
|
PyExtreme
changed the title
|
@fmassa , I have added transforms for center_crop, five_crop and ten_crop. Please note that in the tests of five_crop and ten_crop, there is a mismatch between tensors. So, I have made the modifications accordingly. |
fmassa
pushed a commit
to fmassa/vision-1
that referenced
this pull request
Jan 28, 2020
…h#1615) * add scriptable transform: center_crop * add test: center_crop * add scriptable transform: five_crop * add scriptable transform: five_crop * add scriptable transform: fix minor issues
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 28, 2020
…#1803) Summary: * add scriptable transform: center_crop * add test: center_crop * add scriptable transform: five_crop * add scriptable transform: five_crop * add scriptable transform: fix minor issues Pull Request resolved: #1803 Reviewed By: lerks Differential Revision: D19598584 Pulled By: fmassa fbshipit-source-id: 6cd619da2982aed00104300b9086cc8ca69ecd82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I will add scriptable transforms #1375 for center_crop, five_crop and ten_crop along with the tests.