Fix mypy type annotations #1696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eellison
approved these changes
Dec 21, 2019
zhangguanheng66
force-pushed
the
fix-mypy
branch
3 times, most recently
from
bfcf96c to
062b874
Compare
|
Awesome, thanks a lot for finishing it @zhangguanheng66 ! |
fmassa
added a commit
to fmassa/vision-1
that referenced
this pull request
Jun 9, 2020
* Fix mypy type annotations * follow torchscript Tuple type * redefine torch_choice output type * change the type in cached_grid_anchors * minor bug Co-authored-by: Guanheng Zhang <[email protected]> Co-authored-by: Guanheng Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we need to specify return annotations to be compliant with mypy.