Skip to content

make "rotate" function support grayscale images #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

make "rotate" function support grayscale images #1777

wants to merge 1 commit into from

Conversation

qfgaohao
Copy link

fix issue #1776

@qfgaohao qfgaohao requested a review from fmassa January 20, 2020 03:52
@pmeier
Copy link
Collaborator

pmeier commented Jan 20, 2020

Hi, thanks for the PR. I already opened a PR for the fix in #1760. It also handles incompatible pillow versions, thus your PR is a subset of mine.

@pmeier pmeier mentioned this pull request Jan 20, 2020
Merged
4 tasks
@fmassa
Copy link
Member

fmassa commented Jan 21, 2020

Thanks a lot for the PR @qfgaohao !

Given what @pmeier said, I propose that we continue the work on #1760.

Let me know if you have questions

@fmassa fmassa closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa Awaiting requested review from fmassa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qfgaohao @pmeier @fmassa