Skip to content

Fix Windows build by renaming Python init functions #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2020
Merged

Fix Windows build by renaming Python init functions #1779

merged 1 commit into from
Jan 22, 2020

Conversation

peterjc123
Copy link
Contributor

Fixes #1756.

@peterjc123 peterjc123 requested a review from fmassa January 22, 2020 05:36
@peterjc123 peterjc123 changed the title Fix Windows build by adding Python init functions WIP: Fix Windows build by adding Python init functions Jan 22, 2020
@codecov-io
Copy link

codecov-io commented Jan 22, 2020 •
edited
Loading

Codecov Report

Merging #1779 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1779   +/-   ##
======================================
  Coverage    0.28%   0.28%           
======================================
  Files          92      92           
  Lines        7349    7349           
  Branches     1108    1108           
======================================
  Hits           21      21           
  Misses       7320    7320           
  Partials        8       8
Impacted Files Coverage Δ
torchvision/models/detection/mask_rcnn.py 0% <0%> (ø) ⬆️
torchvision/models/detection/keypoint_rcnn.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5e972a...ad61f63. Read the comment docs.

@peterjc123 peterjc123 changed the title WIP: Fix Windows build by adding Python init functions WIP: Fix Windows build by renaming Python init functions Jan 22, 2020
@peterjc123 peterjc123 changed the title WIP: Fix Windows build by renaming Python init functions Fix Windows build by renaming Python init functions Jan 22, 2020
@peterjc123 peterjc123 requested review from fmassa and removed request for fmassa January 22, 2020 13:07
fmassa
fmassa approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

@fmassa fmassa merged commit e2a8b41 into pytorch:master Jan 22, 2020
fmassa pushed a commit to fmassa/vision-1 that referenced this pull request Jan 28, 2020
@peterjc123 @fmassa
Fix Windows build by renaming Python init functions (pytorch#1779)
c2196ed
facebook-github-bot pushed a commit that referenced this pull request Jan 28, 2020
@peterjc123 @facebook-github-bot
Fix Windows build by renaming Python init functions (#1779)
c2cfe02 
Summary: Pull Request resolved: #1821

Reviewed By: qasfb

Differential Revision: D19599435

Pulled By: fmassa

fbshipit-source-id: d4225e3c73686cfd8cf5846c38ac8e3691df1081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly build failure on Windows
3 participants
@peterjc123 @codecov-io @fmassa