Skip to content

Fix the issue: InceptionE should use different instances of FloatFunctional #1948 #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

hx89
Copy link
Contributor

@hx89 hx89 commented Mar 9, 2020

Fix the issue #1948 to use different instances of FloatFunctional in InceptionE.

Copy link
Contributor

@raghuramank100 raghuramank100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmassa : This was an error in the original InceptionE quantized model and the current model is also going to be replaced in a follow up PR. The change itself is simple.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@fmassa fmassa merged commit ae4012e into master Mar 10, 2020
@fmassa fmassa deleted the inception-fix branch March 10, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants