Making ASPP-Layer in DeepLab more generic #2174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment in the ASPP-Layer the number of output channels are predefined as a constant, which is good for DeepLab but not necessairly in other projects, where another out-channel Nr. is required. Also the number of "atrous rates" is fixed to three, which also could be sometimes more or less depending on the notwork-arch. Again these fixed values may make sense in DeepLab-Model but not necessarily in other type of models. This pull-req. contains the needed changes to make ASPP-Layer generic.
Codecov Report
@@ Coverage Diff @@
## master #2174 +/- ##
======================================
Coverage 0.48% 0.48%
======================================
Files 92 92
Lines 7442 7440 -2
Branches 1135 1136 +1
======================================
Hits 36 36
+ Misses 7393 7391 -2
Partials 13 13
Continue to review full report at Codecov.
|
fmassa
pushed a commit
to fmassa/vision-1
that referenced
this pull request
Jul 8, 2020
At the moment in the ASPP-Layer the number of output channels are predefined as a constant, which is good for DeepLab but not necessairly in other projects, where another out-channel Nr. is required. Also the number of "atrous rates" is fixed to three, which also could be sometimes more or less depending on the notwork-arch. Again these fixed values may make sense in DeepLab-Model but not necessarily in other type of models. This pull-req. contains the needed changes to make ASPP-Layer generic.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 8, 2020
Summary: At the moment in the ASPP-Layer the number of output channels are predefined as a constant, which is good for DeepLab but not necessairly in other projects, where another out-channel Nr. is required. Also the number of "atrous rates" is fixed to three, which also could be sometimes more or less depending on the notwork-arch. Again these fixed values may make sense in DeepLab-Model but not necessarily in other type of models. This pull-req. contains the needed changes to make ASPP-Layer generic. Pull Request resolved: #2427 Reviewed By: zhangguanheng66 Differential Revision: D22432655 Pulled By: fmassa fbshipit-source-id: d8c135807ae35f2d7611898a130642afed101e8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment in the ASPP-Layer, the number of output channels is predefined as a constant,
which is good for DeepLab but not necessarily in other projects, where another out-channel Nr. is required.
Also the number of "atrous rates" is fixed to three, which also could be sometimes more or less depending on the network-arch.
Again these fixed values may make sense in DeepLab-Model but not necessarily in other types of models.
This pull-req. contains the needed changes to make ASPP-Layer generic.
See here.