Skip to content

Clean-up torchscript workaround for builtin all #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2020
Merged

Clean-up torchscript workaround for builtin all #2249

merged 1 commit into from
May 21, 2020

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented May 21, 2020

torchscript now supports all natively, so no need to use the workaround implementation

@fmassa fmassa requested a review from eellison May 21, 2020 16:43
eellison
eellison approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@fmassa fmassa merged commit 3d65fc6 into pytorch:master May 21, 2020
@fmassa fmassa deleted the clean-delteme_all branch May 21, 2020 18:03
fmassa added a commit to fmassa/vision-1 that referenced this pull request Jun 9, 2020
@fmassa
Clean-up delteme_all (pytorch#2249)
ef67e1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmassa @eellison