Skip to content

[WIP] Implement torchvision.utils.draw_bounding_boxes #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

[WIP] Implement torchvision.utils.draw_bounding_boxes #2631

wants to merge 11 commits into from

Conversation

sumanthratna
Copy link
Contributor

@sumanthratna sumanthratna commented Aug 29, 2020 •
edited
Loading

see #2556 for details

status:

  • implements torchvision.utils.draw_bounding_boxes
  • adds appropriate tests
  • adds appropriate docs

CC @pmeier

@oke-aditya
Copy link
Contributor

Hey @sumanthratna are you working on this? Can I work together with this and help in getting it merge 😃

@sumanthratna
Copy link
Contributor Author

Hey @sumanthratna are you working on this? Can I work together with this and help in getting it merge 😃

Hi @oke-aditya! I, unfortunately, can't work on this anymore because of school—but please do contribute! I've added you as a collaborator to my fork but feel free to open a new PR if you want!

@oke-aditya
Copy link
Contributor

oke-aditya commented Oct 6, 2020 •
edited
Loading

Let me try. I would refactor a bit.
Also, use the torchvision native read_image function that was introduced recently instead of PIL.
Let me have a go !

I will continue on this PR. It looks half done and I don't want your contributions to go uncounted 😅

@pmeier
Copy link
Collaborator

pmeier commented Oct 6, 2020

@oke-aditya I'm unsubscribing for now. Ping me when you are done.

@sumanthratna sumanthratna marked this pull request as ready for review October 6, 2020 19:43
@oke-aditya oke-aditya mentioned this pull request Oct 10, 2020
Merged
3 tasks
@sumanthratna
Copy link
Contributor Author

closing in favor of #2785. thanks @oke-aditya!

@sumanthratna sumanthratna deleted the draw_bboxes branch December 20, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumanthratna @oke-aditya @pmeier