Skip to content

Added cuda and torch.jit tests for rgb-hsv tensor conversion ops #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2020
Merged

Added cuda and torch.jit tests for rgb-hsv tensor conversion ops #2639

merged 2 commits into from
Sep 2, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Sep 1, 2020

Description:

  • Added cuda and torch.jit tests for _rgb2hsv and _hsv2rgb methods.

@vfdev-5 vfdev-5 changed the title Added cuda torch.jit tests for rgb-hsv tensor conversion ops Added cuda and torch.jit tests for rgb-hsv tensor conversion ops Sep 1, 2020
@vfdev-5 vfdev-5 marked this pull request as draft September 1, 2020 23:28
@vfdev-5 vfdev-5 marked this pull request as ready for review September 2, 2020 08:42
@vfdev-5 vfdev-5 requested a review from fmassa September 2, 2020 08:43
fmassa
fmassa reviewed Sep 2, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general, but I think there is a change I pointed out that might make the test flaky, can you have a look?

fmassa
fmassa approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fmassa fmassa merged commit ca3d193 into pytorch:master Sep 2, 2020
@vfdev-5 vfdev-5 deleted the vfdev-5/rgb-hsv-cuda-tests branch September 2, 2020 10:16
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
@vfdev-5 @bryant1410
Added cuda and torch.jit tests for rgb-hsv tensor conversion ops (pyt…
726694a 
…orch#2639)

* Added cuda torch.jit tests for rgb-hsv tensor conversion ops

* Reverted deleted test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vfdev-5 @fmassa