-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Adds docs and Fixes Imports for ops and io #2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2654 +/- ##
=======================================
Coverage 72.57% 72.57%
=======================================
Files 95 95
Lines 8249 8249
Branches 1309 1309
=======================================
Hits 5987 5987
Misses 1855 1855
Partials 407 407
Continue to review full report at Codecov.
|
Hi @oke-aditya , sorry for delay, we discussed with @fmassa about this PR and we think that exposing For torchvision ops, they were not included in 0.3.0 release, but now we may consider them as more mature and make them public. Let me comment what we would to remove and we can merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oke-aditya I left few comment. If you could handle that it would be perfect and we can merge this PR after that. Thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks @oke-aditya !
* Adds docs and fixes improts for ops and io * reverts io and init for images
* Adds docs and fixes improts for ops and io * reverts io and init for images
Closes #2649 .
Adds docs for
Image reading functions here
Torchvision ops from boxes.py.
Some functions were missing in the
__init__.py
files, I have added those imports too.Please review and do let me know if changes are needed.
cc @vfdev-5 @fmassa @pmeier