-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[documentation] video API documentation and wrapper #2778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
685f9a3
initial API documentation attempt
bjuncek e5d2527
test the docs
bjuncek 6b696eb
initial commit
bjuncek 0fc157d
updating test to match the registration
bjuncek afef7df
adding the warning on unsucessful import
bjuncek 3c0f6ff
Try to do conditional import
bjuncek f41c92f
Merge branch 'master' into bkorbar/videoAPI/pythonreg
bjuncek 677a28d
Simple fix?
bjuncek 8a9b350
Merge branch 'bkorbar/videoAPI/pythonreg' of github.com:bjuncek/visio…
bjuncek 0faccc5
clearing up docs
bjuncek c7b45e7
Merge branch 'bkorbar/videoAPI/pythonreg' into bkorbar/docs/videoapi
bjuncek 5da68e1
docstring commit
bjuncek 41b2363
Adding types in arguments
bjuncek bd1a3dd
reverting warning commit
bjuncek 428655a
addressing Francisco's comments
bjuncek 5557337
Apply suggestions from code review
bjuncek 4091525
Merge branch 'bkorbar/docs/videoapi' of github.com:bjuncek/vision int…
bjuncek 92c0da1
Revert "reverting warning commit"
bjuncek 2829f1c
Revert "adding the warning on unsucessful import"
bjuncek 175ba32
remove warnings import
bjuncek 5503861
Merge branch 'master' into bkorbar/docs/videoapi
bjuncek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a follow-up PR: given that we are wrapping our C++ class in a python class, we don't need to have this as is, and we can instead implement everything outside the guard, but have a guard at instantiation time.
Something like
In here, we create a function
_has_video_opt
to make the class work with torchscript (which doesn't support globals).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added to the list of issues to address