Added annotation typing to mnasnet #2856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2856 +/- ##
=======================================
Coverage 73.36% 73.37%
=======================================
Files 99 99
Lines 8787 8790 +3
Branches 1387 1387
=======================================
+ Hits 6447 6450 +3
Misses 1916 1916
Partials 424 424
Continue to review full report at Codecov.
|
fmassa
reviewed
Oct 22, 2020
torchvision/models/mnasnet.py
Outdated
| import torch.nn as nn | ||
| from .utils import load_state_dict_from_url | ||
| from torch.jit.annotations import Dict, List |
There was a problem hiding this comment.
Given that we now use Python3, you can now import Dict and List from typing.
There was a problem hiding this comment.
Also, this is not very important as a change, but it is a nice cleanup that could be done
There was a problem hiding this comment.
Oh I thought it was for jittability reasons on those specific types. I'll update the other PRs too then!
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* style: Added annotation typing for mnasnet * refactor: Removed un-necessary import
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* style: Added annotation typing for mnasnet * refactor: Removed un-necessary import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
As per #2025, annotation typing are welcome in torchvision. So, this PR focuses on
torchvision.models.mnasnetthis PR !Any feedback is welcome!