Skip to content

Fixed problem with test error computation between results #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2020
Merged

Fixed problem with test error computation between results #2964

merged 1 commit into from
Nov 6, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Nov 5, 2020 •
edited
Loading

Description:

  • fixed problem with error computation between results: absent abs op to properly compute MAE, max AE.
  • refactored tensor cast for resize: using _cast_squeeze_in and _cast_squeeze_out
    • put clamp outside _cast_squeeze_out
  • fixed round usage: now we use round if we cast to integral type only (from float)

@vfdev-5
House keeping improvements:
d3a7727 
- fixed problem with error computation between results
- refactored tensor cast for resize
- fixed round usage
@codecov
Copy link

codecov bot commented Nov 5, 2020 •
edited
Loading

Codecov Report

Merging #2964 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2964      +/-   ##
==========================================
- Coverage   73.43%   73.41%   -0.03%     
==========================================
  Files          99       99              
  Lines        8813     8805       -8     
  Branches     1391     1388       -3     
==========================================
- Hits         6472     6464       -8     
  Misses       1916     1916              
  Partials      425      425
Impacted Files Coverage Δ
torchvision/transforms/functional_tensor.py 73.67% <100.00%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b61a5c...d3a7727. Read the comment docs.

fmassa
fmassa approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit f655e6a into pytorch:master Nov 6, 2020
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
@vfdev-5 @bryant1410
House keeping improvements: (pytorch#2964)
160781f 
- fixed problem with error computation between results
- refactored tensor cast for resize
- fixed round usage
vfdev-5 added a commit to Quansight/vision that referenced this pull request Dec 4, 2020
@vfdev-5
House keeping improvements: (pytorch#2964)
3bfaf9e 
- fixed problem with error computation between results
- refactored tensor cast for resize
- fixed round usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vfdev-5 @fmassa @facebook-github-bot