Skip to content

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Nov 10, 2020

The rgbalpha_pytorch.png file added in PR #2984 was not an actual RGB + Alpha Transparency PNG but a Palette file.

Here I replace it with an actual RGB+Alpha png, so that the unit-tests cover the 4 channel case. No changes required in the code. I also correct a typo on the name of the file.

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #2985 (a66f34c) into master (f8ba581) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2985   +/-   ##
=======================================
  Coverage   73.39%   73.39%           
=======================================
  Files          99       99           
  Lines        8825     8825           
  Branches     1391     1391           
=======================================
  Hits         6477     6477           
  Misses       1929     1929           
  Partials      419      419           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ba581...a66f34c. Read the comment docs.

@datumbox datumbox merged commit 80f41f8 into pytorch:master Nov 12, 2020
@datumbox datumbox deleted the bug/rgbalpha_test_file branch November 12, 2020 11:39
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
* Replace the Pallete with an RGB + Alpha file.

* Correct typo on name.
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
* Replace the Pallete with an RGB + Alpha file.

* Correct typo on name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants