Skip to content

[DOC] Added paper citation for DeformConv2d #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2020
Merged

[DOC] Added paper citation for DeformConv2d #3000

merged 3 commits into from
Nov 16, 2020

Conversation

hassiahk
Copy link
Contributor

As described in #2975, I have added citation of the paper in the documentation of DeformConv2d and also mentioned about DeformConv v2.

datumbox
datumbox reviewed Nov 13, 2020
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Could you please resolve the lint problem?

@hassiahk
Copy link
Contributor Author

I fixed it! Can you review it once again?

fmassa
fmassa reviewed Nov 13, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Can you also keep the citation from the previous paper? The current implementation in torchvision supports both modes, if mask is None we dispatch to the original deform conv paper.

@codecov
Copy link

codecov bot commented Nov 13, 2020 •
edited
Loading

Codecov Report

Merging #3000 (8029b99) into master (80f41f8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3000   +/-   ##
=======================================
  Coverage   73.39%   73.39%           
=======================================
  Files          99       99           
  Lines        8825     8825           
  Branches     1391     1391           
=======================================
  Hits         6477     6477           
  Misses       1929     1929           
  Partials      419      419
Impacted Files Coverage Δ
torchvision/ops/deform_conv.py 72.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f41f8...8029b99. Read the comment docs.

@hassiahk
Copy link
Contributor Author

I have added the citation of the original paper too. Kindly review it once again.

fmassa
fmassa approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fmassa fmassa merged commit afd9d4d into pytorch:master Nov 16, 2020
@fmassa fmassa mentioned this pull request Nov 16, 2020
Closed
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
@hassiahk @bryant1410
[DOC] Added paper citation for DeformConv2d (pytorch#3000)
29c95f6 
* [DOC] Added paper citation for DeformConv2d

* Fixes Pylint error

* Added citation of the previous paper
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
@hassiahk @vfdev-5
[DOC] Added paper citation for DeformConv2d (pytorch#3000)
e4a45bb 
* [DOC] Added paper citation for DeformConv2d

* Fixes Pylint error

* Added citation of the previous paper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox left review comments

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hassiahk @datumbox @fmassa @facebook-github-bot