Refactoring and moving MobileNetV2 to make it reusable #3177
Conversation
datumbox
changed the title
|
@fmassa I tried doing the changes incrementally so that we can keep the git blame history but git is acting up when we squash. I can try splitting this PR into two:
The above could also be achieved by restructuring the commits and using "merge commit" instead of "squash and merge". Unfortunately, no matter how we do it, it has the side-effect that leaves temporarily the master broken for 1 commit. Thus we will need to squash the two PRs when we sync FBcode. Despite the hassle I prefer this approach from merging this version as is; I think maintaining the history is beneficial. Thoughts? |
Codecov Report
@@ Coverage Diff @@
## master #3177 +/- ##
=======================================
Coverage 73.48% 73.49%
=======================================
Files 99 101 +2
Lines 9230 9235 +5
Branches 1476 1477 +1
=======================================
+ Hits 6783 6787 +4
Misses 1991 1991
- Partials 456 457 +1
Continue to review full report at Codecov.
|
…sses and methods.
|
Let's merge this PR as is, |
Summary: * Moving mobilenet.py to mobilenetv2.py * Adding mobilenet.py for BC. * Extending ConvBNReLU for reuse. * Reduce import scope on mobilenet to only the public and versioned classes and methods. Reviewed By: fmassa Differential Revision: D25679211 fbshipit-source-id: 72d8eadeef42a93879bbe4a61b6611023db29669
This PR works on the prerequisites for supporting other MobileNet models.
Changes:
mobilenet.pytomobilenetv2.pyin a BC way.ConvBNReLUclass to be reusable and support more activation functions.It's going to be easier to review the PR by checking individual commits.