[WIP] Unify checking for Sequence and Number #3318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belay that, it does seem to have problems. |
voldemortX
changed the title
|
I just realized Sequence is not listed as supported in torchscript and there seems to be no recent plan to support it, closing PR. P.S. Union is coming in 1.8.0 though, maybe some workarounds can be removed after that. |
|
Yes that's the reason. And +1 on removing the workarounds once Union support becomes available. This is going to make the codebase much cleaner. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #3200, I want to unify checking for Sequence instead of
int or listand numbers.Number instead ofint or floatin this separate PR. Only changing the checks and docs should not concern torchscript.Not sure if this is what you meant back then? @datumbox