Add download tests for MNIST #3336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
datumbox
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
LGTM. I confirmed that the failing tests are caused by an upstream issue and that master fails as well.
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 4, 2021
Summary: * cleanup * mnist * lint Reviewed By: datumbox Differential Revision: D26226618 fbshipit-source-id: bbe1de7b782ba7915636357cb7bedff782e84b2e Co-authored-by: vfdev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, cleanup the other tests a little more.