Add tests for the STL10 dataset #3345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Feb 3, 2021
| root, data = places365 | ||
|
|
||
| dataset = torchvision.datasets.Places365(root, download=True) | ||
| self.assertIsInstance(repr(dataset), str) | ||
|
|
||
|
|
||
| class STL10Tester(DatasetTestcase): |
There was a problem hiding this comment.
After adding the tests for Places365 we agreed on creating a separate test case for a dataset if more than the generics are checked
pmeier
commented
Feb 3, 2021
| @@ -28,7 +30,7 @@ | |||
| HAS_PYAV = False | |||
|
|
|||
|
|
|||
| class Tester(unittest.TestCase): | |||
| class DatasetTestcase(unittest.TestCase): | |||
There was a problem hiding this comment.
This was necessary since STL10Tester needs access to generic_classification_dataset_test without subclassing Tester directly. Otherwise running STL10Tester would also run all inherited test.
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 10, 2021
Summary: * extract some functionality from places365 fakedata for common use * add a common DatasetTestcase * add fakedata generation and tests for STL10 * lint Reviewed By: fmassa Differential Revision: D26341418 fbshipit-source-id: 05f8a60c986c32f64339197ea377efc6c4d5b238 Co-authored-by: Francisco Massa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.