Skip to content

[android][test_app] Cleanup duplicate dependency #3428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2021
Merged

[android][test_app] Cleanup duplicate dependency #3428

merged 2 commits into from
Feb 23, 2021

Conversation

IvanKobzarev
Copy link
Contributor 

implementation 'org.pytorch:torchvision_ops:0.0.1-SNAPSHOT'

duplicates dependency

localImplementation project(':ops')

Which can lead to build errors with multiple torchvision_ops.so

Will add nightly dimension back with proper dependency (nighlyImplementation) after publishing with proper version.

Testing:

gradle -p android test_app:assembleFrcnnMnetv3CameraLocalDebug

@IvanKobzarev IvanKobzarev requested a review from fmassa February 22, 2021 18:23
fmassa
fmassa approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 67b2528 into pytorch:master Feb 23, 2021
facebook-github-bot pushed a commit that referenced this pull request Mar 4, 2021
@zhangguanheng66 @facebook-github-bot
Cleanup duplicate dependency (#3428)
4424171 
Summary: Co-authored-by: Francisco Massa <[email protected]>

Reviewed By: fmassa

Differential Revision: D26756265

fbshipit-source-id: 7864539dcbc53ecf4379d8ba6b66bc8554c0479f
@datumbox datumbox added bug and removed fix labels Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
bug cla signed topic: build topic: mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IvanKobzarev @fmassa @NicolasHug @datumbox @facebook-github-bot